Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redback] Denylist for Syft #5748

Merged

Conversation

arpitvaghela
Copy link
Contributor

Description

Adding denylist for syft to explicitly deny methods and classes.
This will help us tackle security issues that may arise on moving syft libs support out of syft.

Affected Dependencies

How has this been tested?

  • Manually

Checklist

@arpitvaghela arpitvaghela changed the title added denylist [Redback] Denylist for Syft Jun 30, 2021
@arpitvaghela
Copy link
Contributor Author

denylist

Note: Remove pandas.read_csv and pandas.read_json in syft/libs/pandas/__init__.py before merging.

@iamtrask
Copy link
Member

Would love to learn more about the decision to enforce a policy using a denylist instead of (or perhap sin addition to) an allowlist. For example, if numpy introduced a new method "read_json_v2" and we didn't notice, would that create a vulnerability by which someone could access the file system?

@arpitvaghela
Copy link
Contributor Author

We are still following an allowlist policy, but since we are planning on moving the lib support out, we are added a denylist in syft itself that looks into allowlist of libs (which may or may not be created by us) and deny methods that may cause issues.

@madhavajay madhavajay merged commit e5151bd into OpenMined:feature/redback Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants