Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Redback]: Script Update #5852

Merged
merged 13 commits into from
Aug 9, 2021
Merged

[Redback]: Script Update #5852

merged 13 commits into from
Aug 9, 2021

Conversation

Param-29
Copy link
Contributor

@Param-29 Param-29 commented Jul 29, 2021 •
edited
Loading

Description

  • Creates jupyter-notebook in missing_return folder
  • Added support for ignorelists

Affected Dependencies

  • None

How has this been tested?

  • 0.5.0 tests

Checklist

@Param-29 Param-29 changed the title pydp fix, finally :) [Redback]: Script Update Jul 29, 2021
@arpitvaghela arpitvaghela mentioned this pull request Aug 3, 2021
Closed
@Param-29
Get data from notebooks done.
c08d114
@Param-29
Merge branch 'redblack-v1' of https://github.com/Param-29/PySyft into…
7e02978 
… redblack-v1
@Param-29
Fixing CI
7f00a3e 
: removed arguments from global and moved to main function
@Param-29
CI fix:
2da2dbf 
Added default arguments
@Param-29
CI works
f477011 
: Finally
@arpitvaghela arpitvaghela mentioned this pull request Aug 8, 2021
Merged
4 tasks
@madhavajay madhavajay self-requested a review August 9, 2021 06:48
madhavajay
madhavajay approved these changes Aug 9, 2021
View reviewed changes
Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and added some changes.

@madhavajay madhavajay merged commit f1e439a into OpenMined:feature/redback Aug 9, 2021
madhavajay added a commit that referenced this pull request Aug 9, 2021
@madhavajay
Merge pull request #5890 from arpitvaghela/arpit/nb_support
1fc25dd 
Redback | Support and Update Extension for #5852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhavajay madhavajay madhavajay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Param-29 @madhavajay