Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add small note on Windows path related to Tox #7701

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

snehilsanyal
Copy link
Contributor

@snehilsanyal snehilsanyal commented Jun 4, 2023

Description

A small note included to notebooks/api/0.8/00-load-data.ipynb on Tox and Windows path with/without spaces. The note would be helpful for developers working on MS Windows while setting up the development environment for PySyft.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@rasswanth-s rasswanth-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done @snehilsanyal

rasswanth-s

This comment was marked as duplicate.

@rasswanth-s rasswanth-s merged commit 1bd8806 into OpenMined:dev Jun 6, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants