-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Randomizing default helm credentials #8180
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Param-29
changed the title
Randomizing default helm credentials
[WIP] Randomizing default helm credentials
Oct 19, 2023
fixed error with mongosecret naming
Suggestions:
|
rasswanth-s
reviewed
Nov 7, 2023
rasswanth-s
reviewed
Nov 7, 2023
one for mongo, other for syft
from local testing
|
Param-29
changed the title
[WIP] Randomizing default helm credentials
Randomizing default helm credentials
Nov 15, 2023
|
rasswanth-s
reviewed
Nov 28, 2023
rasswanth-s
reviewed
Nov 28, 2023
rasswanth-s
reviewed
Nov 28, 2023
Co-authored-by: Param-29 <param.mirani1999@gmail.com>
- Deduplicated values in mongo-secret
- Removed seaweedfs username during randomization
- Added a new field for mongo username in values.yaml
- As environment variables cannot have hypens - And cluster names cannot have underscores - These are required for passing the password as environment variables to test randomization
- Add environment variable mapping for randomized password in tox
rasswanth-s
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @Param-29 🚀 🎸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist