Adding __repr__ for container workload classes
#8337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
`SyftWorkerImage`, `SyftWorkerImageTag`, `ContainerImageRegistry` Co-authored-by: Peter Chung <peterchung241@gmail.com>
|
Before building image SyftWorkerImage repr After building image |
|
should we change something about this repr? |
|
|
|
|
Co-authored-by: Peter Chung <peterchung241@gmail.com>
|
|
|
|
|
@khoaguin can you resolve merge conflict and merge with dev |
shubham3121
reviewed
Dec 13, 2023
…ebook to show their `repr`
add `images` and `worker_pools` properties for `DomainClient` remove the `dockerfile_name` column in `SyftWorkerImage List` table
|
|
…ictTuple` - Can get a list of images and worker pools with `client.images` or `client.worker_pools` - Remove some unnecessary `__repr_html__` functions
|
|
for `WorkerPool` and `SyftWorker` Co-authored-by: Kien Dang <mail@kien.ai>
updates in `SyftWorker`
unnecessary attributes for `WorkerPool` and `SyftWorker`
attribute for `WorkerPool` and `SyftWorker` - handle their `_coll_repr_` functions when `image` not exists
shubham3121
reviewed
Jan 1, 2024
shubham3121
reviewed
Jan 1, 2024
shubham3121
reviewed
Jan 1, 2024
…rkers by making an API call to the server
- get SyftWorker's healthcheck by making the worker.status API call to the server
|
Updated after having default worker pool in dev
|
|
|
|
|
- add config as searchable attribute for `SyftWorkerImage` - remove config as unique attribute for `SyftWorkerImage`
…not using memory workers - make some small changes to the api notebook to fix bugs and show repr
|
When using
|
- add a utility method for worker status and healthcheck update - referesh status on resolving worker in worker pool - running and healthy workers derived from workers - skip status checks for in mem workers Co-authored-by: rasswanth <43314053+rasswanth-s@users.noreply.github.com>
shubham3121
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving these issues:
Summary of what this PR does:
<client>.imagesshould show a table containing only the main ones:id, image_tag, image_hash, created_atclient.worker_poolswould be preferred over client.worker_pool.get_all()tag = "openmined/test-nginx:0.7.8", we can index worker image withclient.images[tag]client.worker_poolsshow a list of worker pools withid, pool_name, workers, healthy (healthy/all), running (running/all), image tag/name, created_atclient.worker_pools[tag]client.worker_poolsand after a table of workers show workers' informationclient.worker_pools[0].workersshows all the workerid, image tag/name, resources pool name, healthcheck (healthy/unhealthy), status (created/running/stopped), jobworker = client.worker_pools[0].workers[0], then worker will showid/name, image tag, worker pool name, healthy, status