DS/DO Flow for Request/Approve CustomImage #8398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- create CreateImageChange class to create image on approve - add a method on DockerWokerConfig to check if we can build image locally - Co-authored-by: Khoa Nguyen <dkn.work@protonmail.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
shubham3121
changed the title
…eate pools for DS - create `CreateCustomWorkerPoolChange` class to create a pool upon approval Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
from a DS's pool creation request
khoaguin
force-pushed
the
dsdo-image-requestapproval
branch
from
40f9393
to
3336712
Compare
- remove worker_image.create_image_request API
…rPoolService - add some nb tests into api notebook 10
…_creation_request
- add some asserts to container image notebook
creation request approval cycle - add some type annotations for `syft/tests/conftest`
- revert API to use DATA_SCIENTIST_ROLE
…ages - rename the test file due to typo in filename
picking the wrong image to launch worker pool
instead of always picking the last one to approve since the order might be wrong when testing with container stack
shubham3121
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist