-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubernetes custom worker builder #8417
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
khoaguin
reviewed
Jan 25, 2024
yashgorana
force-pushed
the
yash/k8s-builder
branch
from
January 25, 2024 17:45
d53cac1
to
57db1ef
Compare
yashgorana
force-pushed
the
yash/k8s-builder
branch
from
January 25, 2024 19:56
57db1ef
to
e13d039
Compare
rasswanth-s
reviewed
Jan 29, 2024
rasswanth-s
reviewed
Jan 29, 2024
rasswanth-s
reviewed
Jan 29, 2024
rasswanth-s
approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well Done @yashgorana 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://github.com/OpenMined/Heartbeat/issues/892
Kaniko can build and push in a single job. Since build & push are two separate Syft APIs, it becomes a bit non-trivial to have kaniko build twice... first with
--no-push
and then with--destination
. To keep things aligned with the API-stack, this PR adds build and push as two separate steps without the need of an internal registry:There are some tradeoffs when using crane or internal registry, hence chose this method as it's the simplest and requires the least amount of maintenance.
PS - Crane is used by Kaniko itself.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist