Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes custom worker builder #8417

Merged
merged 17 commits into from
Jan 29, 2024
Merged

Kubernetes custom worker builder #8417

merged 17 commits into from
Jan 29, 2024

Conversation

yashgorana
Copy link
Contributor

@yashgorana yashgorana commented Jan 24, 2024

Description

Closes https://github.com/OpenMined/Heartbeat/issues/892

Kaniko can build and push in a single job. Since build & push are two separate Syft APIs, it becomes a bit non-trivial to have kaniko build twice... first with --no-push and then with --destination. To keep things aligned with the API-stack, this PR adds build and push as two separate steps without the need of an internal registry:

  • Kaniko builds the image and saves it as a tar file on a shared volume
  • Crane pushes the tar image to the provided registry (without rebuilding)

There are some tradeoffs when using crane or internal registry, hence chose this method as it's the simplest and requires the least amount of maintenance.

PS - Crane is used by Kaniko itself.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@yashgorana yashgorana changed the title Kubernetes builder Kubernetes custom worker builder Jan 24, 2024
Copy link
Collaborator

@rasswanth-s rasswanth-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done @yashgorana 🚀

@rasswanth-s rasswanth-s merged commit df90d16 into dev Jan 29, 2024
32 checks passed
@rasswanth-s rasswanth-s deleted the yash/k8s-builder branch January 29, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants