Fix kubernetes cloud deployment issues #8447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashgorana
added
Type: Bug 🐛
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
yashgorana
commented
Feb 2, 2024
yashgorana
commented
Feb 2, 2024
yashgorana
commented
Feb 2, 2024
yashgorana
removed
the
Type: Bug 🐛
rasswanth-s
reviewed
Feb 6, 2024
rasswanth-s
reviewed
Feb 6, 2024
rasswanth-s
reviewed
Feb 6, 2024
rasswanth-s
reviewed
Feb 6, 2024
rasswanth-s
reviewed
Feb 6, 2024
rasswanth-s
approved these changes
Feb 6, 2024
rasswanth-s
reviewed
Feb 6, 2024
shubham3121
approved these changes
Feb 6, 2024
|
|
||
| class ImageUtils: | ||
| @staticmethod | ||
| def parse_tag(tag: str) -> Tuple[Optional[str], str, str]: |
There was a problem hiding this comment.
NITPICK: I think we can make them as independent functions, instead of static methods.
There was a problem hiding this comment.
This is just a way to group similarly related functions in a namespace in this case "ImageUtils", so i get all the functions in one import. Also keeps the code a bit neater. Is it a much-needed change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://github.com/OpenMined/Heartbeat/issues/964, https://github.com/OpenMined/Heartbeat/issues/966, https://github.com/OpenMined/Heartbeat/issues/971, https://github.com/OpenMined/Heartbeat/issues/968
This change fixes PVC MultiAttach error with the following fixes:
credentials-datavolume is now a Secret that is mounted to all the worker pods. This way credentials-data will becomeReadWriteOncemounted only by the backend pod.worker-buildsPVC is removed and internal registry is added as a cache. Build always pushes to internal registry. Push copies it from internal to remote registry.Additionally refactored core kubernetes helper functions
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist