Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 - ADD Notifier Settings for Admin view #8488

Merged
merged 2 commits into from Feb 15, 2024
Merged

3 - ADD Notifier Settings for Admin view #8488

merged 2 commits into from Feb 15, 2024

Conversation

IonesioJunior
Copy link
Member

Description

  • Add notifier settings for admin view

@IonesioJunior IonesioJunior changed the base branch from dev to enable_notifier_service February 14, 2024 13:24
jcardonnet
jcardonnet approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jcardonnet jcardonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type should be something like Union[NotifierSettingsView, SyftError] instead of Union[NotifierStash, SyftError], but I'll fix it myself after I create the NotifierSettingsView class.

@jcardonnet jcardonnet merged commit f4de4a0 into enable_notifier_service Feb 15, 2024
4 checks passed
@jcardonnet jcardonnet deleted the feature/notifier_settings branch February 15, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcardonnet jcardonnet jcardonnet approved these changes

Assignees

@jcardonnet jcardonnet

@IonesioJunior IonesioJunior

Labels
Blue Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IonesioJunior @jcardonnet