Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5 - ADD Notifier turn off service #8490

Merged
merged 2 commits into from Feb 15, 2024
Merged

5 - ADD Notifier turn off service #8490

merged 2 commits into from Feb 15, 2024

Conversation

IonesioJunior
Copy link
Member

Description

  • Enable Notifier Service to be turned off.

jcardonnet
jcardonnet reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@jcardonnet jcardonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we ensure the stash update was successful/check for errors before returning Syft Success/Error?

@IonesioJunior
Copy link
Member Author

IonesioJunior commented Feb 14, 2024 •
edited

Should we ensure the stash update was successful/check for errors before returning Syft Success/Error?

Yup! Good catch! Fixed it in the last commit! :)

jcardonnet
jcardonnet approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@jcardonnet jcardonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IonesioJunior IonesioJunior merged commit 8046670 into enable_notifier_service Feb 15, 2024
4 checks passed
@IonesioJunior IonesioJunior deleted the feature/turn_off_notifier branch February 15, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcardonnet jcardonnet jcardonnet approved these changes

Assignees

@jcardonnet jcardonnet

@IonesioJunior IonesioJunior

Labels
Blue Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IonesioJunior @jcardonnet