Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable notifications via settings api #8506

Merged
merged 1 commit into from Feb 19, 2024

Conversation

IonesioJunior
Copy link
Member

Using the new Notifier Service, the node admin must be able to enable/disable the node notifier.

But to achieve that, there are some edge cases to keep in mind.

  • By UX/UI reasons, the api used to enable / disable it will be set at client.settints.
    • To enable: client.settings.enable_notifications(token=<TOKEN>)
    • To disable: client.settings.disable_notifications()
  • If email token isn't provided, returns a SyftError informing that email_token parameter is mandatory.
  • If a regular user tries to use this API, it must receive the regular PySyft non authorized error.
  • If admin provides all the informations properly, it will return a SyftSuccess message.

Copy link
Contributor

@jcardonnet jcardonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from feature/integration_with_postmark to notifier February 19, 2024 21:05
@jcardonnet jcardonnet merged commit 825f685 into notifier Feb 19, 2024
4 checks passed
@jcardonnet jcardonnet deleted the feature/enable_notifications_via_settings branch February 19, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants