Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Veilid Prototype Iteration 2 #8526

Merged
merged 68 commits into from Mar 13, 2024
Merged

Veilid Prototype Iteration 2 #8526

merged 68 commits into from Mar 13, 2024

Conversation

rasswanth-s
Copy link
Collaborator

@rasswanth-s rasswanth-s commented Feb 24, 2024

Description

How has this been tested?

  • Add an integration test

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

add transformation for node routes
unified veilid constants in veilid_endpoints.py
add a test notebook for connections
Added notebook for testing to connect domain to a gateway
tox.ini Show resolved Hide resolved
@@ -859,7 +863,7 @@ commands =
bash -c 'NODE_NAME=syft NODE_PORT=${NODE_PORT} && \
k3d cluster create syft -p "$NODE_PORT:80@loadbalancer" --registry-use k3d-registry.localhost || true \
k3d cluster start syft'
tox -e dev.k8s.patch.coredns
CLUSTER_NAME=syft tox -e dev.k8s.patch.coredns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you don't need to do this. This command's CLUSTER_NAME will automatically pass to tox -e dev.k8s.patch.coredns

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nevermind, the collapsed git diff created some confusion. This is a different command. You can just use the tox -e dev.k8s.start. It will automatically patch the coredns for you as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will address the same in next PR for refactoring the syft.test.helm tox test 👍

packages/syft/src/syft/client/client.py Outdated Show resolved Hide resolved
packages/syft/src/syft/client/client.py Outdated Show resolved Hide resolved
packages/syft/src/syft/client/client.py Show resolved Hide resolved
packages/syft/src/syft/client/client.py Outdated Show resolved Hide resolved
packages/syft/src/syft/client/client.py Outdated Show resolved Hide resolved
packages/syft/src/syft/client/client.py Outdated Show resolved Hide resolved
Copy link
Member

@shubham3121 shubham3121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome Work @rasswanth-s as always 🔥 💯 🥇 🕺🏾 !!!

Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is such an epic job @rasswanth-s ! You should feel extremely proud of yourself.

@rasswanth-s
Copy link
Collaborator Author

Merging the PR, as the tests are highly flaky, due to which, I have been re-starting the tests from morning

@rasswanth-s rasswanth-s merged commit a14ae2c into dev Mar 13, 2024
34 of 35 checks passed
@rasswanth-s rasswanth-s deleted the rasswanth/veilid-prototype branch March 13, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants