[K8s] Parametrize tox task #8531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasswanth-s
commented
Feb 27, 2024
tox.ini
Outdated
| @@ -981,23 +984,29 @@ commands = | |||
| description = Deploy Syft to a local Kubernetes cluster with Devspace | |||
| changedir = {toxinidir}/packages/grid | |||
| passenv=HOME, USER | |||
| setenv= | |||
| KUBE_CONTEXT = {env:KUBE_CONTEXT:k3d-syft-dev} | |||
| DEVSPACE_PROFILE = {env:DEVSPACE_PROFILE:} | |||
There was a problem hiding this comment.
For launching gateway it could be like
CLUSTER_NAME="syft-gateway" NODE_PORT=9081 tox -e dev.k8s.start
KUBE_CONTEXT="k3d-syft-gateway" DEVSPACE_PROFILE="-p gateway" tox -e dev.k8s.hotreload
There was a problem hiding this comment.
Since kubecontext is basically k3d-$CLUSTER_NAME, it's redundant. I'll push an update for this.
yashgorana
approved these changes
Mar 4, 2024
|
Thank you for the cleanup @yashgorana , the commands are even more simpler now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, for launching multiple clusters or same machine , we would have to manually modify the config in tox or deploy one by helm and other by devspace.
The PR adds parametrization by environment variables, until we have syft cli, which automates deployment of multiple clusters on local machine
How has this been tested?
Manually
Checklist