Test Network Functionalities and Fix Related Bugs #8568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when launching gateway nodes
This comment was marked as resolved.
This comment was marked as resolved.
`sy.gateways` and `sy.domains` - on fixing bugs for `sy.domains` Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
from a hardcoded dict of networks
in `online_networks` and `online_domains`
and `sy.domains` into network integration test
to be a `dict[str(UID), NodePeer]` instead of a `list[NodePeer]`
integration gateway test
be accessible by guest so that `sy.search<dataset_name>` works
This comment was marked as outdated.
This comment was marked as outdated.
- add test for `sy.search` functionality
khoaguin
changed the title
Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
to the domain in `test_dataset_search` Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
delete dataset service. Change its use in `gateway_test` integration test accordingly
or network registry. Change tests to use the env var
shubham3121
approved these changes
Apr 4, 2024
|
Nice work @khoaguin with the fixes !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Syft's networking functionalities, including
sy.gatewaysand domains withsy.domainssy.searchusingThreadPoolExecutorProxyClientto the domain clientAnd also fix related bugs (https://github.com/OpenMined/Heartbeat/issues/1140) and some improvements (https://github.com/OpenMined/Heartbeat/issues/1139)
How has this been tested?
Added some integration tests in
tests/integration/network/gateway_test.py