SeaweedFS Remote Mount #8660
Merged
SeaweedFS Remote Mount #8660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
rasswanth-s
reviewed
Apr 11, 2024
| @@ -100,8 +104,6 @@ spec: | |||
| secretKeyRef: | |||
| name: {{ .Values.seaweedfs.secretKeyName | required "seaweedfs.secretKeyName is required" }} | |||
| key: s3RootPassword | |||
| - name: S3_PORT | |||
There was a problem hiding this comment.
Q: Why did we remove the S3_PORT ?
There was a problem hiding this comment.
Probably, as there is no extra usefulness, is allowing users to customize this port?
There was a problem hiding this comment.
Not needed & not used. No point customizing the port as we're in a container environment and they can just port forward whatever to 8333
There was a problem hiding this comment.
You can still provide it as through backend.env in values.yaml
rasswanth-s
reviewed
Apr 11, 2024
rasswanth-s
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes https://github.com/OpenMined/Heartbeat/issues/1149
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist