Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix widget repr for ActionObject #8668

Merged
merged 5 commits into from Apr 5, 2024
Merged

Fix widget repr for ActionObject #8668

merged 5 commits into from Apr 5, 2024

Conversation

eelcovdw
Copy link
Contributor

@eelcovdw eelcovdw commented Apr 4, 2024 •
edited

Description

  • split ActionObject.__repr__() in two methods. Thought I needed it for PR, ended up not using it but it looks better
  • add separate widget repr handling for ActionObject

example with larger action object:
image

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@eelcovdw
Copy link
Contributor Author

eelcovdw commented Apr 4, 2024

merge after #8658

@eelcovdw eelcovdw self-assigned this Apr 4, 2024
abyesilyurt
abyesilyurt approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@abyesilyurt abyesilyurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eelcovdw eelcovdw merged commit 5443a86 into dev Apr 5, 2024
35 checks passed
@eelcovdw eelcovdw deleted the eelco/fix-action-object-diff-repr branch April 5, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abyesilyurt abyesilyurt abyesilyurt approved these changes

Assignees

@eelcovdw eelcovdw

Labels
0.8.7 Red Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eelcovdw @abyesilyurt