Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget HTML cleanup #8681

Merged
merged 9 commits into from Apr 10, 2024
Merged

Widget HTML cleanup #8681

merged 9 commits into from Apr 10, 2024

Conversation

eelcovdw
Copy link
Contributor

@eelcovdw eelcovdw commented Apr 8, 2024

Description

Preparation for ObjectDiffBatch repr + various visual fixes

For new reprs/widgets we need to reuse parts of existing HTML reprs, so we need to split them out/modularize them.

  • Move more complex html components to new components module, so we can isolate+re-use them
  • Add copy button to table
  • fix table alignment/overflow
  • rewrite widget header to HTML, re-use diffbatch table HTML

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@eelcovdw eelcovdw requested review from koenvanderveen and tcp and removed request for koenvanderveen April 9, 2024 12:23
@eelcovdw eelcovdw removed the request for review from tcp April 10, 2024 09:05
@eelcovdw eelcovdw enabled auto-merge April 10, 2024 10:02
@eelcovdw eelcovdw merged commit cceabe6 into dev Apr 10, 2024
35 checks passed
@eelcovdw eelcovdw deleted the eelco/copy-button branch April 10, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants