Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[syft] syft client + jupyter image #8699

Merged
merged 4 commits into from Apr 15, 2024
Merged

Conversation

yashgorana
Copy link
Contributor

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@yashgorana
Copy link
Contributor Author

Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works awesome, but... I do wonder should we call it something else because people might confuse it for the syft "whole thing".

Maybe syft-jupyter or syft-client or something?

Copy link
Collaborator

@rasswanth-s rasswanth-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Maybe we could keep it syft-jupyter ? , as it would be easy to understand.

@yashgorana
Copy link
Contributor Author

Successful build & push to ACR - https://github.com/OpenMined/PySyft/actions/runs/8684032712

@yashgorana yashgorana merged commit ebddbb0 into dev Apr 15, 2024
37 checks passed
@yashgorana yashgorana deleted the yash/syft-client-container branch April 15, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants