Add podLabels podAnnotations to Helm Charts

[yashgorana]

Description

This is to support GKE and any cloud-specific configurations

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

• Describe the tests that you ran to verify your changes.
• Provide instructions so we can reproduce.
• List any relevant details for your test configuration.

Checklist

• I have followed the Contribution Guidelines and Code of Conduct
• I have commented my code following the OpenMined Styleguide
• I have labeled this PR with the relevant Type labels
• My changes are covered by tests

[yashgorana]

@eelcovdw i have relaxed the resourcePresets in this PR.
backend=xlarge (4 cpu 8gb max)
seaweed=xlarge (4 cpu 8gb max)
mongo=large (2cpu 4gb max)
proxy=small (0.5cpu 1GB max)
frontend=medium (1cpu 2GB max)

in a separate pr i'll update worker pools to use 4xlarge presets (8cpu and 16gb min)

[rasswanth-s]

Q: Why are we removing this ?

[yashgorana]

Not really required. Because (1) not exposed to the net and (2) the idea is to avoid dynamic port assignment for simplicity and follow standard port numbers for internal apis.

[rasswanth-s]

When we input mutiple podsLabels , it takes the last one.

Example Values files

node:
    podLabels:
        test/label: 5
        test/label: 2

Output

[rasswanth-s]

But if I reverse the order

It takes the last one

[rasswanth-s]

It should take into account all the pod labels?

[yashgorana]

This is valid & expected. metadata.labels & metadata.annotations are a map and not list. Both kubernetes and golang templating will hold only one value because underlying struct is a go map. You also see a squigly error line under your YAML because that's validation failure 😉

[rasswanth-s]

Ahh ok, is there a way such that a user could provide multiple pod annotations to pod spec by helm values?

[yashgorana]

Yes it is supported and this change implements it (example), but k8s spec has explicit directives for the type of values the labels and annotations must have. Since keys-values must be strings, often times k8s providers will expect a JSON string as values (GKE example)