Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert release changes #8713

Merged
merged 3 commits into from Apr 17, 2024
Merged

Revert release changes #8713

merged 3 commits into from Apr 17, 2024

Conversation

rasswanth-s
Copy link
Collaborator

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be

syft_base_worker_tag = (
    "local-dev"
    if (bool(os.environ["DEV_MODE"]) and running_as_container)
    else sy.__version__
)
syft_base_worker_tag

as of commit 2c59b87, change was introduced with commit d2c0258

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 4ea3646

Copy link
Contributor

@yashgorana yashgorana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the syft_base_worker_tag

@yashgorana yashgorana merged commit e8e3579 into dev Apr 17, 2024
35 checks passed
@yashgorana yashgorana deleted the rasswanth/revert_release_changes branch April 17, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants