Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle empty kwargs and high state update in high-to-low case #8718

Merged
merged 11 commits into from Apr 18, 2024

Conversation

abyesilyurt
Copy link
Contributor

Bug fixes:

  • Fixed is_execution_on_owned_args when kwargs is empty.
  • Fixed ObjectDiff showing modified after syncing by applying empty state.
    Thanks @eelcovdw for the help.

Test updates:

  • Updated tests to check for the bugs above.
  • Extended twin api integration test. I need to update it with the changes from Custom api and worker #8693
  • Seperated sync tests into two files. New one is using the new flow with resolve_single, while the old one is still using resolve.

Some extra prints and docs:

  • Added a reminder to __getattribute__ error message to call .refresh().
  • Added a docstr to AnyActionObject.
  • Added a warning print when a widget has an unused share button.

@abyesilyurt abyesilyurt changed the title bug fix for empty kwargs on user code and not updating sync state in high-to-low case fix: handle empty kwargs and high state update in high-to-low case Apr 18, 2024
@eelcovdw eelcovdw merged commit 6063d51 into dev Apr 18, 2024
35 checks passed
@eelcovdw eelcovdw deleted the aziz/job_modified_bug branch April 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants