Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support GKE Workload Identity #8733

Merged
merged 17 commits into from Apr 24, 2024
Merged

feat: support GKE Workload Identity #8733

merged 17 commits into from Apr 24, 2024

Conversation

tcp
Copy link
Collaborator

@tcp tcp commented Apr 23, 2024

Description

  • Add service account to build & push jobs to support workload identity
  • Global option to directly push to registry instead of using the local registry
  • Switch to krane that supports workload identity for pushing images
  • Run worker pool with the service account same as backend's service account.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@tcp tcp changed the title Workload identity feat: support for GKE Workload Identity Apr 23, 2024
@tcp tcp changed the title feat: support for GKE Workload Identity feat: support GKE Workload Identity Apr 23, 2024
@tcp tcp added the Black Team label Apr 23, 2024
@tcp tcp requested a review from yashgorana April 23, 2024 06:48
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tcp tcp self-assigned this Apr 24, 2024
@yashgorana yashgorana merged commit 41bc3ba into dev Apr 24, 2024
35 checks passed
@yashgorana yashgorana deleted the workload-identity branch April 24, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants