add a method to delete/kill the consumer in the thread #8754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -567,6 +571,18 @@ def add_consumer_for_service( | |||
| ) | |||
| consumer.run() | |||
|
|
|||
| def remove_consumer_with_id(self, syft_worker_id: UID) -> None: | |||
| for _, consumers in self.queue_manager.consumers.items(): | |||
There was a problem hiding this comment.
I am not sure how to parse the following datastructure, we have a: Client that has multiple consumers. How does that work? Doesnt every consumer need its own client?
koenvanderveen
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
Fix: For in memory workers, consumer thread is not killed when worker is deleted
https://files.slack.com/files-pri/T6963A864-F0704PM06J3/screenshot_2024-04-25_at_2.49.54_pm.png
Fix: Skip updating consumer state when corresponding worker object is deleted from the stash
