Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api_endpoints() view for DS #8757

Merged
merged 3 commits into from Apr 25, 2024
Merged

Fix api_endpoints() view for DS #8757

merged 3 commits into from Apr 25, 2024

Conversation

IonesioJunior
Copy link
Member

Description

Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Copy link
Contributor

@eelcovdw eelcovdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style comment, rest looks good to go!

if isinstance(node, ast.FunctionDef)
][0]
mock_function_name = NOT_ACCESSIBLE_STRING
if self.mock_function != NOT_ACCESSIBLE_STRING:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to keep the NOT_ACCESSIBLE_STRING only to the repr methods, and have self.mock_function be None if it is not defined:

if self.mock_function is None:
    mock_function_name = NOT_ACCESSIBLE_STRING
else:
    # parse function name

Same in api.py:562

That would clear the logic here up a lot I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved by: b56b3e1

@eelcovdw eelcovdw enabled auto-merge April 25, 2024 15:24
@eelcovdw eelcovdw merged commit 06bef76 into dev Apr 25, 2024
35 checks passed
@eelcovdw eelcovdw deleted the fix_api_endpoints_for_ds branch April 25, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants