Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added diff report tests #154

Merged
merged 1 commit into from Jul 9, 2020
Merged

Added diff report tests #154

merged 1 commit into from Jul 9, 2020

Conversation

mjjimenez
Copy link
Collaborator

Description

Adds model diff report tests (part of feature tests here: #122 )

Checklist

@mjjimenez mjjimenez added the Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase label Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #154 into master will increase coverage by 0.69%.
The diff coverage is 82.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   52.49%   53.19%   +0.69%     
==========================================
  Files          16       16              
  Lines        1861     1861              
==========================================
+ Hits          977      990      +13     
+ Misses        884      871      -13     
Impacted Files Coverage Δ
SwiftSyft/Classes/APIPayload.swift 78.78% <ø> (ø)
SwiftSyft/Classes/SyftPlan.swift 7.54% <ø> (ø)
SwiftSyft/Classes/SyftRTCClient.swift 0.00% <0.00%> (ø)
SwiftSyft/Classes/NetworkManager.swift 73.07% <75.00%> (ø)
SwiftSyft/Classes/PingChecker.swift 81.25% <75.00%> (ø)
SwiftSyft/Classes/SyftClient.swift 80.92% <91.66%> (+5.23%) ⬆️
SwiftSyft/Classes/DownloadService.swift 75.86% <100.00%> (-13.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25d5874...3ba1e9b. Read the comment docs.

@cereallarceny cereallarceny merged commit c0152b9 into master Jul 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the report-tests branch July 9, 2020 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants