add serialization support in tensors #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
added
the
Type: New Feature ➕
bcebere
changed the title
bcebere
requested review from
youben11 and
philomath213
and removed request for
youben11
youben11
requested changes
Jul 22, 2020
| @@ -1,12 +1,40 @@ | |||
| import tenseal as ts | |||
There was a problem hiding this comment.
Nice spot for the filename lol
…nsor_serialization
…enSEAL into tensor_serialization
youben11
requested changes
Jul 23, 2020
philomath213
requested changes
Jul 23, 2020
|
This is really great work, it will allow us to build and try client/server scenarios easily. |
youben11
requested changes
Jul 23, 2020
There was a problem hiding this comment.
The PR is looking amazing!
I just left a quick remark about the Python API for creating tensors, and I'm also wondering about pickling: I see that it's still serializing the context, right? I don't won't to bother you with that on this PR but I think we can track a new issue about optimizing this that can be summarized in the following points:
- When pickling, serialize the vector only
- When unpickling, deserialize the vector only, setting its context to nullptr
- Add a method for linking vectors with a context
- Vectors shouldn't be operational while not linked to a context
- The vector shouldn't be operational after unpickling until it has been linked to a context
youben11
approved these changes
Jul 23, 2020
Co-authored-by: Ayoub Benaissa <ayouben9@gmail.com>
Co-authored-by: Ayoub Benaissa <ayouben9@gmail.com>
Co-authored-by: Ayoub Benaissa <ayouben9@gmail.com>
Co-authored-by: Ayoub Benaissa <ayouben9@gmail.com>
Co-authored-by: Ayoub Benaissa <ayouben9@gmail.com>
pierreeliseeflory
pushed a commit
to pierreeliseeflory/TenSEAL
that referenced
this pull request
Apr 27, 2022
* add serialization support in tensors * add python support * add gtests * tensor serialization tests * Update tenseal/tensors/__init__.py Co-authored-by: Ayoub Benaissa <ayouben9@gmail.com> Co-authored-by: Bilal Retiat <bilalphilomath@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Protobuff support for tensors
fixes #72
Checklist