CKKSTensor: complete dot operation #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
added
Type: Improvement 📈
bcebere
reviewed
Jan 25, 2021
| // TODO: better implement broadcasting for mul first then would be | ||
| // implemented similar to 1D-1D | ||
| throw invalid_argument("1D-2D dot isn't implemented yet"); | ||
| if (this_shape[0] != other_shape[0]) |
There was a problem hiding this comment.
Why isn't valid for
this_shape[0] == other_shape[1]
?
There was a problem hiding this comment.
We need the vector size to match the first dimension of the matrix to perform the dot product
bcebere
approved these changes
Jan 25, 2021
tenseal/cpp/tensors/ckkstensor.cpp
Outdated
| throw invalid_argument("can't perform dot: dimension mismatch"); | ||
| // TODO: remove boradcast when implemented in _mul | ||
| auto other_copy = other->copy(); | ||
| other_copy->_data.reshape_inplace( |
There was a problem hiding this comment.
This could be directly
auto other_copy = other->reshape( ...
tenseal/cpp/tensors/ckkstensor.cpp
Outdated
| throw invalid_argument("2D-1D dot isn't implemented yet"); | ||
| if (this_shape[1] != other_shape[0]) | ||
| throw invalid_argument("can't perform dot: dimension mismatch"); | ||
| // TODO: remove boradcast when implemented in _mul |
| if (this_shape[1] != other_shape[0]) | ||
| throw invalid_argument("can't perform dot: dimension mismatch"); | ||
| // TODO: remove boradcast when implemented in _mul | ||
| auto other_copy = other; |
There was a problem hiding this comment.
maybe
auto other_copy = other.reshape(...
directly?
There was a problem hiding this comment.
other here is a const and can't call reshape directly, just kept this, but the rest is updated
pierreeliseeflory
pushed a commit
to pierreeliseeflory/TenSEAL
that referenced
this pull request
Apr 27, 2022
* add 1D-2D dot * fix * reshape before broadcast * fix: return * ignore protobuf changes * 2D-1D dot * separate dot ops again * lint * fix: pass the copy * typos and updates * lint * need to copy plain first Co-authored-by: Bogdan Cebere <bogdan.cebere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dot operations were missing 1D-2D and 2D-1D tensors because of the missing broadcasting operations. Now we have broadcasting and we can complete the dot method.
Checklist