Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel encryption - ckkstensor #289

Merged
merged 8 commits into from
Apr 29, 2021

Conversation

CerineBnsd
Copy link
Contributor

@CerineBnsd CerineBnsd commented Apr 27, 2021

Description

Refactored the code to encrypt the data using multiple threads during the creation of ckkstensor. (related to #200)

Affected Dependencies

None.

How has this been tested?

  • The changes are supposed to be tested by running the same tests that are in 'ckkstensor_test.cpp'. But they are not working for a reason that I couldn't track.

Checklist

@CerineBnsd CerineBnsd closed this Apr 27, 2021
@CerineBnsd CerineBnsd reopened this Apr 27, 2021
@CerineBnsd CerineBnsd changed the title Parallel enc ckkstensor Parallel encryption - ckkstensor Apr 27, 2021
worker_func(0, total_tasks);
return;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you mentionned, we may need to set n_jobs to be the minimum between n_jobs and total_tasks, otherwise, the PR looks good to me, thanks!

@youben11 youben11 added the Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor label Apr 29, 2021
@youben11 youben11 linked an issue Apr 29, 2021 that may be closed by this pull request
@bcebere bcebere requested a review from youben11 April 29, 2021 18:06
@bcebere bcebere merged commit 9877b11 into OpenMined:master Apr 29, 2021
pierreeliseeflory pushed a commit to pierreeliseeflory/TenSEAL that referenced this pull request Apr 27, 2022
* Parallel encryption ckkstensor

* threadsafe encoder

* drop duplicate worker_func code

* update n_jobs

Co-authored-by: Bogdan Cebere <bogdan.cebere@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CKKSTensor creation: parallel encryption
3 participants