-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel encryption - ckkstensor #289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
requested changes
Apr 29, 2021
worker_func(0, total_tasks); | ||
return; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you mentionned, we may need to set n_jobs to be the minimum between n_jobs and total_tasks, otherwise, the PR looks good to me, thanks!
youben11
added
the
Type: Improvement 📈
Performance improvement not introducing a new feature or requiring a major refactor
label
Apr 29, 2021
…AL into parallel_enc_ckkstensor
pierreeliseeflory
pushed a commit
to pierreeliseeflory/TenSEAL
that referenced
this pull request
Apr 27, 2022
* Parallel encryption ckkstensor * threadsafe encoder * drop duplicate worker_func code * update n_jobs Co-authored-by: Bogdan Cebere <bogdan.cebere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Improvement 📈
Performance improvement not introducing a new feature or requiring a major refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactored the code to encrypt the data using multiple threads during the creation of ckkstensor. (related to #200)
Affected Dependencies
None.
How has this been tested?
Checklist