Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple states possible for course filter buttons, clearing them does not reset button states #92

Closed
curt-mitch opened this issue Jan 21, 2021 · 2 comments
Closed

Multiple states possible for course filter buttons, clearing them does not reset button states #92

curt-mitch opened this issue Jan 21, 2021 · 2 comments
Assignees
@curt-mitch
Labels
Type: Bug 🐛 Some functionality not working in the codebase as intended
Projects
Courses 1.0

Comments

@curt-mitch
Copy link
Member

curt-mitch commented Jan 21, 2021 •
edited
Loading

Description

The skill level filter buttons on the courses page mistakenly allow multiple options, and clicking "clear filters" does not reset the button states.

How to Reproduce

  1. Go to courses.openmined.org/courses
  2. Click on one of the skill level buttons ("beginner", "intermediate", "advanced")
  3. Click on the other skill level buttons
  4. Click "clear filters"
  5. See error

Expected Behavior

  1. Since each course only has one skill level, I would expect the filter buttons to only allow one selection at a time.
  2. I would expect the "clear filter" selection to reset the filter button states.

Screenshots

Screen Shot 2021-01-21 at 7 06 37 AM

System Information

  • OS: Mac OS Catalina
  • OS Version: v10.15.7
  • Browser: Brave
  • Browser Version: v1.19.86
@curt-mitch curt-mitch added the Type: Bug 🐛 Some functionality not working in the codebase as intended label Jan 21, 2021
@curt-mitch curt-mitch mentioned this issue Jan 21, 2021
Closed
curt-mitch added a commit to curt-mitch/openmined that referenced this issue Jan 23, 2021
@curt-mitch
Fix for issue OpenMined#92: course filter selection states
1709a26
curt-mitch added a commit to curt-mitch/openmined that referenced this issue Jan 23, 2021
@curt-mitch
Fix for issue OpenMined#92: course filter selection states
3dfc666
@curt-mitch
Copy link
Member Author

@cereallarceny I've got a fix for this if you want to assign the ticket to me.

@cereallarceny cereallarceny added this to To do in Courses 1.0 via automation Jan 26, 2021
@cereallarceny cereallarceny moved this from To do to In progress in Courses 1.0 Jan 26, 2021
@cereallarceny
Copy link
Member

Done @curt-mitch , please link your PR to this issue and DM it to me.

@curt-mitch curt-mitch mentioned this issue Jan 26, 2021
Merged
4 tasks
@tcp tcp moved this from In progress to Review in progress in Courses 1.0 Feb 1, 2021
tcp added a commit that referenced this issue Feb 3, 2021
@tcp
Merge pull request #94 from curt-mitch/dev
484e6f2 
Fix for issue #92: course filter selection states
@tcp tcp closed this as completed Feb 17, 2021
Courses 1.0 automation moved this from Review in progress to Done Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@curt-mitch curt-mitch

Labels
Type: Bug 🐛 Some functionality not working in the codebase as intended
Projects
Courses 1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tcp @cereallarceny @curt-mitch