Update protobuf types and Plan, temporarily rollback Threepio usage #114

vvmnnnkv · 2020-04-12T14:23:33Z

Changes:

Make protobuf and Plan up to date with PySyft and syft-proto
Add unit test that runs MNIST example plan
Temporarily restored legacy translation because Threepio doesn't have all commands we need for MNIST example (examples: sub, truediv, gt); Additionally, even if we fallback to legacy only on commands that Threepio doesn't know, there's still a problem, the plan execution result is incorrect (needs further investigation).

codecov · 2020-04-12T14:25:55Z

Codecov Report

Merging #114 into master will decrease coverage by 0.18%.
The diff coverage is 89.39%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   72.16%   71.97%   -0.19%     
==========================================
  Files          22       24       +2     
  Lines         740      760      +20     
  Branches       93       96       +3     
==========================================
+ Hits          534      547      +13     
- Misses        185      191       +6     
- Partials       21       22       +1

Impacted Files	Coverage Δ
src/protobuf/mapping.js	`100.00% <ø> (ø)`
src/syft-model.js	`0.00% <ø> (ø)`
src/types/message.js	`100.00% <ø> (+5.08%)`	⬆️
src/_errors.js	`53.84% <33.33%> (-0.70%)`	⬇️
src/types/placeholder.js	`94.44% <88.88%> (-5.56%)`	⬇️
src/types/state.js	`90.00% <90.00%> (ø)`
src/types/role.js	`90.47% <90.47%> (ø)`
src/types/computation-action.js	`90.90% <90.90%> (ø)`
src/types/plan.js	`90.00% <100.00%> (-2.31%)`	⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d070f6...f41a93d. Read the comment docs.

vvmnnnkv · 2020-04-12T14:56:29Z

src/types/computation-action.js

+
+import { Threepio, Command } from '@openmined/threepio';
+const threepio = new Threepio('torch', 'tfjs', tf);
+*/


Threepio is temporarily commented out.

vvmnnnkv · 2020-04-12T14:56:37Z

src/types/computation-action.js

+      }
+      const cmd = new Command(functionName, resolvedArgs, this.kwargs);
+      const translation = threepio.translate(cmd);
+      return translation.executeRoutine();


Threepio is temporarily commented out.

Update protobuf types, temporarily rollback threepio usage

78f8f26

vvmnnnkv requested review from cereallarceny and Nolski April 12, 2020 14:23

vvmnnnkv commented Apr 12, 2020

View reviewed changes

Vova Manannikov added 3 commits April 13, 2020 20:55

Enable threepio

442d9f1

Enable threepio (with master branch)

f41a93d

Update threepio, remove legacy translation

2864859

cereallarceny approved these changes Apr 15, 2020

View reviewed changes

cereallarceny merged commit f52a359 into master Apr 15, 2020

delete-merged-branch bot deleted the vvm/protobuf-and-threepio branch April 15, 2020 17:19

cereallarceny mentioned this pull request Apr 15, 2020

WIP Threepio Update #115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update protobuf types and Plan, temporarily rollback Threepio usage #114

Update protobuf types and Plan, temporarily rollback Threepio usage #114

vvmnnnkv commented Apr 12, 2020

codecov bot commented Apr 12, 2020 •

edited

vvmnnnkv Apr 12, 2020

vvmnnnkv Apr 12, 2020

Update protobuf types and Plan, temporarily rollback Threepio usage #114

Update protobuf types and Plan, temporarily rollback Threepio usage #114

Conversation

vvmnnnkv commented Apr 12, 2020

codecov bot commented Apr 12, 2020 • edited

Codecov Report

vvmnnnkv Apr 12, 2020

Choose a reason for hiding this comment

vvmnnnkv Apr 12, 2020

Choose a reason for hiding this comment

codecov bot commented Apr 12, 2020 •

edited