Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation - src/types/placeholder.js #208

Merged
merged 6 commits into from
Aug 10, 2020
Merged

Documentation - src/types/placeholder.js #208

merged 6 commits into from
Aug 10, 2020

Conversation

nahuakang
Copy link
Member

@nahuakang nahuakang commented Aug 5, 2020 •
edited

Description

This PR address inline documentation for Issue #134 on PlaceholderId and Placeholder.

NOTE: Outstanding questions include:

  • What Placeholder.getOrderFromTags method does
  • How to make PlaceholderId and Placeholder classes sound more simplified and non-abstract
  • Double check if the types for the static unbufferize methods are labeled correctly

Affected Dependencies

N/A

How has this been tested?

N/A

Checklist

@nahuakang nahuakang added the Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase label Aug 5, 2020
@cereallarceny
Copy link
Member

Good to me @nahuakang. Merge when you approve @vvmnnnkv.

@nahuakang
Copy link
Member Author

I got a better understanding about Placeholder now so I'll work on the documentation again this evening 😃

@nahuakang nahuakang marked this pull request as ready for review August 6, 2020 16:35
@nahuakang nahuakang requested a review from vvmnnnkv August 6, 2020 16:36
@cereallarceny cereallarceny merged commit 02bd806 into dev Aug 10, 2020
@cereallarceny cereallarceny deleted the documentation/placeholder branch August 10, 2020 16:41
@cereallarceny cereallarceny mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cereallarceny cereallarceny cereallarceny approved these changes

@vvmnnnkv vvmnnnkv Awaiting requested review from vvmnnnkv

Assignees
No one assigned
Labels
Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nahuakang @cereallarceny