Avoid Buffer and crypto dependencies #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvmnnnkv
added
Type: Bug 🐛
vvmnnnkv
added
the
Status: Review Needed 🙋
cereallarceny
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #196.
Original problem is in buffer library, similar to aws-amplify/amplify-js#678
But since Buffer was used only for decoding/encoding base64, I removed its usage replacing with tiny library that does only base64. Same for crypto dependency - replaced it with utility func that creates random buffer.
Affected Dependencies
n/a
How has this been tested?
Created html file with TF.js and syft.js included, and MNIST example contents and checked it works.
Checklist