Remove old serde; update unit tests #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #96 +/- ##
===========================================
+ Coverage 71.15% 85.97% +14.81%
===========================================
Files 21 18 -3
Lines 676 556 -120
Branches 85 80 -5
===========================================
- Hits 481 478 -3
+ Misses 174 67 -107
+ Partials 21 11 -10
Continue to review full report at Codecov.
|
vvmnnnkv
moved this from In progress
to Review in progress
in Model-centric Federated Learning
cereallarceny
suggested changes
Feb 8, 2020
cereallarceny
approved these changes
Feb 8, 2020
Model-centric Federated Learning
automation
moved this from Review in progress
to Reviewer approved
Feb 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #83: as we currently have Protocols and Plans migrated to protobuf and simple demo working with that, we can now remove old serde code.
This change also adds more unit tests to cover new and existing code, and fixes some issues found while adding unit tests.