-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IoTerop] Add Objects 18830 and 18831. #355
Conversation
Signed-off-by: David Navarro <david.navarro@ioterop.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks very good. Few minor things to consider.
18830.xml
Outdated
</Item> | ||
<Item ID="8"> | ||
<Name>MQTT Broker Public Key</Name> | ||
<Operations>W</Operations> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be readable too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. This is modified in the new commit.
--> | ||
<LWM2M xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://www.openmobilealliance.org/tech/profiles/LWM2M-v1_1.xsd"> | ||
<Object ObjectType="MODefinition"> | ||
<Name>MQTT Publication</Name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is not the actual publication (as in "publish message") would it make sense to call this e.g., "MQTT Publication Configuration"?
18831.xml
Outdated
<Type>Corelnk</Type> | ||
<RangeEnumeration></RangeEnumeration> | ||
<Units></Units> | ||
<Description><![CDATA[The source of the data to publish. If this Resource is empty, the published data are implementation dependent.]]></Description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to have more details here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some examples in the new commit.
<Type>Unsigned Integer</Type> | ||
<RangeEnumeration>0..2</RangeEnumeration> | ||
<Units></Units> | ||
<Description><![CDATA[The Quality of Service value to use when publishing.]]></Description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to describe what each value means
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The QoS is described in the MQTT standard. I did not want to copy/paste the info here.
Signed-off-by: David Navarro <david.navarro@ioterop.com>
@@ -52,7 +52,7 @@ https://ioterop.com/ | |||
<Type>Corelnk</Type> | |||
<RangeEnumeration></RangeEnumeration> | |||
<Units></Units> | |||
<Description><![CDATA[The source of the data to publish. If this Resource is empty, the published data are implementation dependent.]]></Description> | |||
<Description><![CDATA[The source of the data to publish (e.g. "</sensors/temp>", or "</3303/0/5700>;</3336/0>"). If this Resource is empty, the published data are implementation dependent.]]></Description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there still be more details how to interpret the CoRE link in this context? Something link "the client sends the information referenced by the link when ever it changes" (with some notion of change)?
Signed-off-by: David Navarro david.navarro@ioterop.com