[HuaXiang] 10309 #76
Merged
[HuaXiang] 10309 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.We deleted the "Bluetooth" resource,because it isn't the best way to use a specific Wireless chip. 2.We deleted the "LockState" resource,because we can deduce it from other factors. 2.For different application scenarios,we added the "LockType" resource . 3.We changed the "LightState" to "LightSwitchState". 4.For Knowing the device of Wireless state,we added the "RSSI" resource. 5.We changed the "UpTime" to "DataUpTime" and the resource's String types to Time. 6.And we added two new resources variables,which are "Latitude" and "Longitude". "Latitude",which ID is 5514. "Longitude",which ID is 5515.
update file name from ShareParkingLock to 10309.
|
@dengjialean
|
1.We decided to change the name of object 10309 "DeviceDataContainer" to "ShareParkingLock". 2.We think this object should be public.
|
------------------ 原始邮件 ------------------
发件人: "Joaquin"<notifications@github.com>;
发送时间: 2019年2月28日(星期四) 晚上9:48
收件人: "OpenMobileAlliance/lwm2m-registry"<lwm2m-registry@noreply.github.com>;
抄送: "邓嘉"<280858922@qq.com>; "Mention"<mention@noreply.github.com>;
主题: Re: [OpenMobileAlliance/lwm2m-registry] [HuaXiang] 10309 (#76)
@dengjialean
We need to resolve the following issues:
Is "ShareParkingLock" a replacement of "DeviceDataContainer"?
Software license is too restricted. By setting the copyright to Hua Xiang all rights reserved, other companies won't be able to use this Object. Are you considering to have a more open software license?
Incorrect schema filename: LWM2M-v1_0.xsd, should be name LWM2M.xsd.
LwM2M schema is set to v1.0 but the "LWM2MVersion" of the protocol is set to "1.1". This is incorrect. You need to decide if this Object is release for version 1.0 or v1.1 of LwM2M protocol.
URN is set to urn:oma:lwm2m10309:1.0, as this object is the first version (1.0), there is no need to add the Object version to the URN. Therefore, URN needs to be changed to: urn:oma:lwm2m10309
Once the above issues are addressed, we will validate the Object
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
Dear Joaquin,
I'm honored to receive your letter.
I have answered your question one by one.
Please check it on GitHub.
Tank you for your contribution,we beae it in mand.
Best wishes to you.
|
The content of this file has been moved to 10309.xml object
|
We advise you to use functionality from existing objects instead of creating a new object. For instance, please consider the following:
|
|
Editorial changes to range an enumeration and descriptions.
|
Using the decomposition we recommended would have preferable, but given your urgency, we have made only minor edits. In the future we will provide better guidelines for best practices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new pull request template