[Golden maple] Air_Temperature_Humidity - 10310 #82
Conversation
…2m-registry into Golden-maple-data
seanmcilroy29
changed the title
|
Observations
|
|
@seanmcilroy29 I‘ve updated the .xml file, please review, thanks. |
|
@jpradocueva updated, plz review. |
|
@peaceblues the Object is ready for IPSO Working Group discussion, tomorrow Thursday 14th. Please keep an eye in case that further comments are received. You may have to provide another update. If the group agrees with the content it will be merged into the "Golden-maple-data" branch and the staff will move it to publication. |
OMA is aligning the unit symbol to SenML registry: https://www.iana.org/assignments/senml/senml.xhtml In this case, the temperature in Celsius is should represented as "Cel" rather than "C".
|
@jpradocueva, hello, the object has passed the review and published , right? |
|
The Object will be presented to the Working Group @ 1500(GMT).
Please note the working group may decide to have a short review period of the object in order for members to submit comments
From: peaceblues <notifications@github.com>
Sent: 14 March 2019 07:55
To: OpenMobileAlliance/lwm2m-registry <lwm2m-registry@noreply.github.com>
Cc: Sean McIlroy <smcilroy@omaorg.org>; Mention <mention@noreply.github.com>
Subject: Re: [OpenMobileAlliance/lwm2m-registry] [Golden maple] Air_Temperature_Humidity - 10310 (#82)
@jpradocueva<https://github.com/jpradocueva>, hello, the object has passed the review and published , right?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#82 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH7tBSoFsoyITlVtO-Fds1PkA89dLqVlks5vWgBpgaJpZM4bq3Hq>.
|
|
@jpradocueva @seanmcilroy29 Any progress on this? |
|
A few questions were raised during the working group review of the Object, so the Chair has requested a 6-day review period in order for members to submit comments/questions for you to answer. |
There was a problem hiding this comment.
I've made some comments about some smaller issues I've found in this object registration.
However, I'm not sure about the need for this object in general. Objects generally self-contain one functionality such as Temperature, Humidity and Voltage objects already separately exist. This object uses 3 different resources for these 3 already existing objects. At the end, this object does not offer any new functionality in my opinion. It is just a shortcut to use existing objects, by bypassing the principle of "one object one functionality".
| limitations under the License.--> | ||
| <LWM2M xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://www.openmobilealliance.org/tech/profiles/LWM2M-v1_1.xsd"> | ||
| <Object ObjectType="MODefinition"> | ||
| <Name>Air_Temperature_Humidity</Name> |
There was a problem hiding this comment.
It should be full sentences here i.e. Air Temperature Humidity
| <LWM2MVersion>1.1</LWM2MVersion> | ||
| <ObjectVersion>1.0</ObjectVersion> | ||
| <MultipleInstances>Multiple</MultipleInstances> | ||
| <Mandatory>Mandatory</Mandatory> |
There was a problem hiding this comment.
This object cannot be mandatory! Change to Optional
| <Mandatory>Mandatory</Mandatory> | ||
| <Resources> | ||
| <Item ID="1"> | ||
| <Name>air temperature</Name> |
| <MultipleInstances>Single</MultipleInstances> | ||
| <Mandatory>Mandatory</Mandatory> | ||
| <Type>Float</Type> | ||
| <RangeEnumeration>-100~100</RangeEnumeration> |
| <Description><![CDATA[Air temperature]]></Description> | ||
| </Item> | ||
| <Item ID="2"> | ||
| <Name>air humidity</Name> |
| <Description><![CDATA[Air humidity]]></Description> | ||
| </Item> | ||
| <Item ID="3"> | ||
| <Name>voltage</Name> |
| <MultipleInstances>Single</MultipleInstances> | ||
| <Mandatory>Optional</Mandatory> | ||
| <Type>Float</Type> | ||
| <RangeEnumeration>0~24</RangeEnumeration> |
| <Description><![CDATA[Voltage]]></Description> | ||
| </Item> | ||
| <Item ID="4"> | ||
| <Name>report interval</Name> |
| </Item> | ||
| <Item ID="4"> | ||
| <Name>report interval</Name> | ||
| <Operations>W</Operations> |
There was a problem hiding this comment.
Is this resource really meant to have only W access? Why not RW since it is probably easier to manage?
| <MultipleInstances>Single</MultipleInstances> | ||
| <Mandatory>Optional</Mandatory> | ||
| <Type>Integer</Type> | ||
| <RangeEnumeration>1~25</RangeEnumeration> |
|
The units on resource 2, air humidity, should probably be %RH per the new SenML units we are standardizing. |
We would like the submitter to first comment on this suggestion to consider the use of existing objects. |
Company Name: Golden Maple Data Remove global URL
|
@peaceblues - Please note the Working Group are waiting for you to respond to their submitted comments prior to having the Object Approved |
|
@peaceblues please review the latest comments. If we haven't receive any reply by May 16th we will have to close the PR and the registration. Thanks |
|
@peaceblues - Please note the Working Group will be holding a conf call this Thursday [16 MAY]. If no reply has been received the PR and Registration for Air_Temperature_Humidity will be closed. |
|
@peaceblues - Please note the Working Group will be holding a conf call this Thursday [20 Jun]. If no reply has been received the PR and Registration for Air_Temperature_Humidity will be closed |
|
This PR is closed as the submitter has not followed up on the comments from the Group. |
Update to Apache 2.0 License