This repository has been archived by the owner on May 18, 2019. It is now read-only.
Filter parameter results, ticket:3925, ticket:4029 #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the new function `calcParamsSize` starts to count sz at 0; the previous implementation in `calcDataNames` started with 1. Should not matter as there are no aliases to parameters.
|
The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2016-10-24_12-25-31. |
|
The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2016-10-24_12-52-34. |
|
Please squash the commits before merging the pull request. |
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2016-10-24_13-15-31. |
|
I left the additional commit because the offset of 1 is still strange -- regular variables have the offset for time, but parameters? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the new function
calcParamsSizestarts to count sz at 0;the previous implementation in
calcDataNamesstarted with 1.Should not matter as there are no aliases to parameters.