Skip to content
This repository has been archived by the owner on May 18, 2019. It is now read-only.

Separation of back end transformations for simulation and initialization #199

Merged

Conversation

lochel
Copy link
Member

@lochel lochel commented Sep 11, 2015

See #3452.

This pull request will move the generation and optimization of the initialization problem from sim code to back end.
The initialization problem will be handled separately from the simulation problem right after index reduction. Therewith, both systems can be optimized independently during post-optimization.

@lochel lochel force-pushed the early-initialization-v2 branch 2 times, most recently from dffb9d4 to d96b84f Compare September 11, 2015 07:23
lochel added a commit to lochel/OMCompiler that referenced this pull request Sep 11, 2015
* Apply old patch to move initialization before pre-optimization phase
* Revert CodegenC.tpl changes
* Remove workaround for "symEuler"
* Moved 'encapsulateWhenConditions' to pre-optimization phase
* Cleanup known variables after remove simple equations
* Activate more modules for initialization
  - activate modules "simplifyComplexFunction" and "simplifyLoops"
  - Fixed module "simplifyLoops" for initialization
* Moved each post-opt module to a new line
* Moved module "simplifyLoops" from simulation to initialization
* Don't add known vars to simulation system in post-optimization
* Updated debug dumps
* Fixed "Known Variables" again
* Initialize relations properly
* New opt module "removeInitializationStuff"
  - This module does simplifications by removing initialization
    information like homotopy(..) and initial() from simulation DAE.
* Fixed Stubs files
lochel added a commit to lochel/OMCompiler that referenced this pull request Sep 11, 2015
* Move initialization before post-optimization phase
* Revert some CodegenC.tpl changes
* Remove workaround for "symEuler"
* Moved 'encapsulateWhenConditions' to pre-optimization phase
* Cleanup known variables after 'remove simple equations'
* Activate more modules for initialization
  - activate modules "simplifyComplexFunction" and "simplifyLoops"
  - Fixed module "simplifyLoops" for initialization
* Moved each post-opt module to a new line
* Moved module "simplifyLoops" from simulation to initialization
* Don't add known vars to simulation system in post-optimization
* Updated debug dumps
* Fixed "Known Variables" again
* Initialize relations properly
* New opt module "removeInitializationStuff"
  - This module does simplifications by removing initialization
    information like homotopy(..) and initial() from simulation DAE.
* Fixed Stubs files
@OpenModelica-Hudson
Copy link
Member

The job failed the coding style; for details, see OpenModelica_TEST_PULL_REQUEST 2015-09-11_10-01-28. Remember to clean up the commit you did that breaks the coding style rather than piling a new commit on top of the old ones. This goes double for accidental addition of files that you need to remove.

lochel added a commit to lochel/OMCompiler that referenced this pull request Sep 11, 2015
* Move initialization before post-optimization phase
* Revert some CodegenC.tpl changes
* Remove workaround for "symEuler"
* Moved 'encapsulateWhenConditions' to pre-optimization phase
* Cleanup known variables after 'remove simple equations'
* Activate more modules for initialization
  - activate modules "simplifyComplexFunction" and "simplifyLoops"
  - Fixed module "simplifyLoops" for initialization
* Moved each post-opt module to a new line
* Moved module "simplifyLoops" from simulation to initialization
* Don't add known vars to simulation system in post-optimization
* Updated debug dumps
* Fixed "Known Variables" again
* Initialize relations properly
* New opt module "removeInitializationStuff"
  - This module does simplifications by removing initialization
    information like homotopy(..) and initial() from simulation DAE.
* Fixed Stubs files
@OpenModelica-Hudson
Copy link
Member

The job failed to compile; for details, see OpenModelica_TEST_PULL_REQUEST 2015-09-11_10-20-53.

... for simulation and initialization

* Move initialization before post-optimization phase
* Revert some CodegenC.tpl changes
* Remove workaround for "symEuler"
* Moved 'encapsulateWhenConditions' to pre-optimization phase
* Cleanup known variables after 'remove simple equations'
* Activate more modules for initialization
  - activate modules "simplifyComplexFunction" and "simplifyLoops"
  - Fixed module "simplifyLoops" for initialization
* Moved each post-opt module to a new line
* Moved module "simplifyLoops" from simulation to initialization
* Don't add known vars to simulation system in post-optimization
* Updated debug dumps
* Fixed "Known Variables" again
* Initialize relations properly
* New opt module "removeInitializationStuff"
  - This module does simplifications by removing initialization
    information like homotopy(..) and initial() from simulation DAE.
* Fixed Stubs files
@OpenModelica-Hudson
Copy link
Member

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2015-09-11_14-18-36.

@OpenModelica-Hudson OpenModelica-Hudson merged commit 56d186b into OpenModelica:master Sep 11, 2015
@lochel lochel deleted the early-initialization-v2 branch September 14, 2015 07:56
OpenModelica-Hudson pushed a commit to OpenModelica/OpenModelica that referenced this pull request Feb 20, 2016
  > skipped intialation for some tests after structure breaker in OpenModelica/OMCompiler#199
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants