This repository has been archived by the owner on May 18, 2019. It is now read-only.
[NF] Fix some variability issues. #2060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed pre and change to be discrete and ndims to be parameter, as per the specification. - Derive the variability of components with no explicit variability by using their types. - Hacked the variability of relations to be at most discrete to avoid breaking implicitly discrete variables, needs to be fixed properly for e.g. noEvent.
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2017-11-29_17-07-32. |
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Nov 29, 2017
- Changed pre and change to be discrete and ndims to be parameter, as per the specification. - Derive the variability of components with no explicit variability by using their types. - Hacked the variability of relations to be at most discrete to avoid breaking implicitly discrete variables, needs to be fixed properly for e.g. noEvent. Belonging to [master]: - #2060 - OpenModelica/OpenModelica-testsuite#798
OpenModelica-Hudson
pushed a commit
to OpenModelica/OpenModelica-testsuite
that referenced
this pull request
Nov 29, 2017
Belonging to [master]: - OpenModelica/OMCompiler#2060 - #798
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per the specification.
by using their types.
avoid breaking implicitly discrete variables, needs to be fixed
properly for e.g. noEvent.