This repository has been archived by the owner on May 18, 2019. It is now read-only.
Enable Cpp logger under Windows and finalize it, ticket:4773 #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The finalizer shall flush buffers, e.g. of LoggerXMLTCP.
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018-03-01_22-51-37. |
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Mar 1, 2018
The finalizer shall flush buffers, e.g. of LoggerXMLTCP. Belonging to [master]: - #2246
adeas31
reviewed
Mar 2, 2018
| @@ -81,7 +81,7 @@ else | |||
| PARALLEL_OUTPUT_COMMAND=-DUSE_PARALLEL_OUTPUT=OFF | |||
| endif | |||
|
|
|||
| USE_LOGGER="false" | |||
| USE_LOGGER="true" | |||
| ifeq ("$(USE_LOGGER)","true") | |||
There was a problem hiding this comment.
Unfortunately this will not work. This will eventually become,
ifeq (""true"","true")
and will fail. Either get rid of quotes from the assignment or from the if condition. See also my comment on ticket:4773.
There was a problem hiding this comment.
The quotes are removed with: #2252
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The finalizer shall flush buffers, e.g. of LoggerXMLTCP.