This repository has been archived by the owner on May 18, 2019. It is now read-only.
[NF] better error messages and more evaluation of parameters #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
adrpo
commented
Aug 10, 2018
adrpo
commented
- evaluate parameters with annotation(Evaluate=true), make them structural parameters
- give the deduced variability of the expression that doesn't match the expected variability
- fix ticket:5062, add an warning message for parameter Type p(fixed=true) annotation(Evaluate=true); with no binding
- handle ticket:5061 by accepting parameters in the public section of the functions and issue a warning
|
The job failed the coding style; for details, see OpenModelica_TEST_PULL_REQUEST 2018-08-10_23-52-28. Remember to clean up the commit you did that breaks the coding style rather than piling a new commit on top of the old ones. This goes double for accidental addition of files that you need to remove. |
- evaluate parameters with annotation(Evaluate=true), make them structural parameters - give the deduced variability of the expression that doesn't match the expected variability - fix ticket:5062, add an warning message for parameter Type p(fixed=true) annotation(Evaluate=true); with no binding - handle ticket:5061 by accepting parameters in the public section of the functions and issue a warning
adrpo
force-pushed
the
BetterErrorMessages
branch
from
a1abccf
to
63cffc3
Compare
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018-08-10_23-58-47. |
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Aug 10, 2018
- evaluate parameters with annotation(Evaluate=true), make them structural parameters - give the deduced variability of the expression that doesn't match the expected variability - fix ticket:5062, add an warning message for parameter Type p(fixed=true) annotation(Evaluate=true); with no binding - handle ticket:5061 by accepting parameters in the public section of the functions and issue a warning Belonging to [master]: - #2600 - OpenModelica/OpenModelica-testsuite#1012
OpenModelica-Hudson
pushed a commit
to OpenModelica/OpenModelica-testsuite
that referenced
this pull request
Aug 10, 2018
Belonging to [master]: - OpenModelica/OMCompiler#2600 - #1012
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.