This repository has been archived by the owner on May 18, 2019. It is now read-only.
[NF] Improve handling of reductions. #2703
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Separate the handling of array constructors and reductions so reductions can be handled properly. - Implement expansion of type names, to better handle enumeration names as iteration ranges. - Expand enumeration type names in Expression.toDAE, so that they can be converted to DAE-form. - Add missing case for enumeration literals in Expression.compare. - Don't fill in "missing" subscripts in crefs with :, it interfers with reductions in some cases and doesn't seem to have any benefits.
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018-10-08_16-32-42. |
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Oct 8, 2018
- Separate the handling of array constructors and reductions so reductions can be handled properly. - Implement expansion of type names, to better handle enumeration names as iteration ranges. - Expand enumeration type names in Expression.toDAE, so that they can be converted to DAE-form. - Add missing case for enumeration literals in Expression.compare. - Don't fill in "missing" subscripts in crefs with :, it interfers with reductions in some cases and doesn't seem to have any benefits. Belonging to [master]: - #2703 - OpenModelica/OpenModelica-testsuite#1047
OpenModelica-Hudson
pushed a commit
to OpenModelica/OpenModelica-testsuite
that referenced
this pull request
Oct 8, 2018
Belonging to [master]: - OpenModelica/OMCompiler#2703 - #1047
|
Can't wait for the Hudson results 😃 |
|
Job #2386 running... |
|
All right, nothing fancy yet. I'm always hoping for the silver bullet PR, which will cause 1500+ improvements in a single shot, but I guess there is no such thing... |
I would even consider 16 improvements vs. 67 regressions a step back instead of a step forward... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reductions can be handled properly.
as iteration ranges.
converted to DAE-form.
reductions in some cases and doesn't seem to have any benefits.