Skip to content
This repository has been archived by the owner on May 18, 2019. It is now read-only.

generate hashed SVGs in subdirs #2704

Closed
wants to merge 1 commit into from
Closed

generate hashed SVGs in subdirs #2704

wants to merge 1 commit into from

Conversation

hkiel
Copy link
Member

@hkiel hkiel commented Oct 8, 2018

put hash-named SVGs into 16 subdirs according to first letter to reduce number of files in one directory

@hkiel
Copy link
Member Author

hkiel commented Oct 8, 2018

Would it make sense to create hierarchy of files to further reduce the number?
Modelica.Mechanics.Rotational.Examples.Utilities.SpringDamper.svg -> Modelica/Mechanics/Rotational/Examples/Utilities/SpringDamper.svg

@adrpo
Copy link
Member

adrpo commented Oct 8, 2018

It would maybe make it easier to find out what class the svg belongs to, now we have generated hashes that do not tell anything. But you would need to start with the library version number first to make things unique: Modelica_latest/Modelica/Mechanics/Rotational/Examples/Utilities/SpringDamper.svg

@hkiel
Copy link
Member Author

hkiel commented Oct 8, 2018

The hashes are there to save space, so that e.g. the Example icon (green triangle) can be re-used for all example models.
Anyways, with the current scripting it seems that you can only generate documentation of one version of the library. This needs to be changed first. Then we could modify the script to only generate the documentation if the library changed (or the scripts of course).

@OpenModelica-Hudson
Copy link
Member

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018-10-10_10-21-04.

OpenModelica-Hudson pushed a commit that referenced this pull request Oct 10, 2018
Belonging to [master]:
  - #2704
@hkiel hkiel deleted the svg_subdirs branch October 10, 2018 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants