This repository has been archived by the owner on May 18, 2019. It is now read-only.
[NF] Various fixes. #2819
Closed
[NF] Various fixes. #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove the type in Call.CallAttributes, the call itself already contains the same type. - Improve subscripting of calls such as pre(), where the argument can be subscripted instead of the whole call expression. - Fix Type.copyDims so that it doesn't create an array with no dimensions if the source type is a scalar type. - Add simplification 'if ... then x else x' => 'x'.
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018-12-07_16-16-34. |
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Dec 7, 2018
- Remove the type in Call.CallAttributes, the call itself already contains the same type. - Improve subscripting of calls such as pre(), where the argument can be subscripted instead of the whole call expression. - Fix Type.copyDims so that it doesn't create an array with no dimensions if the source type is a scalar type. - Add simplification 'if ... then x else x' => 'x'. Belonging to [master]: - #2819 - OpenModelica/OpenModelica-testsuite#1086
OpenModelica-Hudson
pushed a commit
to OpenModelica/OpenModelica-testsuite
that referenced
this pull request
Dec 7, 2018
Belonging to [master]: - OpenModelica/OMCompiler#2819 - #1086
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contains the same type.
be subscripted instead of the whole call expression.
dimensions if the source type is a scalar type.