This repository has been archived by the owner on May 18, 2019. It is now read-only.
[NF] Improve operator overloading. #2837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement scalar*array, array*scalar and array/scalar for overloaded operators. - Improve TypeCheck.implicitConstructAndMatch so that it checks that the constructed argument actually matches the expected type for the operator, to avoid it matching e.g. scalars with operators that only take arrays.
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2018-12-14_18-45-18. |
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Dec 14, 2018
- Implement scalar*array, array*scalar and array/scalar for overloaded operators. - Improve TypeCheck.implicitConstructAndMatch so that it checks that the constructed argument actually matches the expected type for the operator, to avoid it matching e.g. scalars with operators that only take arrays. Belonging to [master]: - #2837 - OpenModelica/OpenModelica-testsuite#1095
OpenModelica-Hudson
pushed a commit
to OpenModelica/OpenModelica-testsuite
that referenced
this pull request
Dec 14, 2018
Belonging to [master]: - OpenModelica/OMCompiler#2837 - #1095
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operators.
constructed argument actually matches the expected type for the
operator, to avoid it matching e.g. scalars with operators that only
take arrays.