Skip to content
This repository has been archived by the owner on May 18, 2019. It is now read-only.

Add some example auto-completion information on Annotations for use by OMEdit (task#5333) #2958

Closed
wants to merge 1 commit into from
Closed

Conversation

atrosinenko
Copy link
Contributor

@atrosinenko
Copy link
Contributor Author

Ping

@atrosinenko
Copy link
Contributor Author

This is supposed to be not a work-in-progress, but finished extension point where OMCompiler developers who know more about actual annotations may trivially add content.

@casella
Copy link

casella commented Mar 18, 2019

@atrosinenko, the title of the PR was a bit misleading, because it lacked the information that it was all about annotations. I'd gladly work on this, but I won't have time for a while.

I guess all the relevant information can be found here: https://webref.modelica.university/, in the bottom right corner (I'm not sure why @mtiller called it "Statements", I guess it should have been "annotations"). Maybe you want to give it a try?

@atrosinenko
Copy link
Contributor Author

I guess all the relevant information can be found here: https://webref.modelica.university/

Great cheat sheet, thanks!

Right now, I fear copy-paste is inappropriate for legal reason and my rewordings may be wrong/misleading. On the other hand, this PR is not supposed to be complete for now -- it have not to be complete, it just have to be correct, placed to the right part of the right library, etc. It is merely a placeholder for demonstration of OpenModelica/OMEdit#219.

So, I expect review of this PR to be review of the future layout of the content. And just a small bit of actual information.

@atrosinenko
Copy link
Contributor Author

Even more, in the future, other completion info (such as keywords) could probably be moved there. But, of course, this PR is about annotations.

@atrosinenko atrosinenko changed the title Add some example auto-completion information for use by OMEdit (task#5333) Add some example auto-completion information on Annotations for use by OMEdit (task#5333) Mar 18, 2019
@adeas31
Copy link
Member

adeas31 commented Mar 21, 2019

I tested a bit OpenModelica/OMEdit#219. Seems to work fine. We can either merge this PR for now or can use this one to fill in all the annotations. @casella you think you can manage that?

@casella
Copy link

casella commented Mar 21, 2019

Not before April 8th, I'm totally swamped

@adeas31
Copy link
Member

adeas31 commented Mar 22, 2019

Don't bother then....I will add it myself.

@adeas31
Copy link
Member

adeas31 commented Mar 22, 2019

I added annotations based on the latest Modelica specification. There are few TODO in the code, I am not sure how to handle such cases.

Copy link

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm sorry but I don't have the time to check against the Specification right now

@OpenModelica-Hudson
Copy link
Member

The test suite is unstable according to OpenModelica_TEST_PULL_REQUEST 2019-04-02_15-14-23.

@OpenModelica-Hudson
Copy link
Member

The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2019-04-02_16-48-52.

OpenModelica-Hudson pushed a commit to OpenModelica/OpenModelica-testsuite that referenced this pull request Apr 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants