This repository has been archived by the owner on May 18, 2019. It is now read-only.
[NF] Improve error checking of when-clauses. #3001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the check of equations inside when-equations from Inst to Typing, to allow skipping the check if the when is clocked. - Mark lhs subscripts in when-equations as structural. - Added check that clocked when doesn't have an elsewhen. - Added check that non-clocked when doesn't have a clocked elsewhen. - Made clocked when illegal in algorithm. - Added new phase VerifyModel that checks for errors that can't be detected until after flattening and constant evaluation. It currently checks that each branch of a when-equation contains the same set of crefs. - Implemented BaseAvlSet.isEqual. - Renamed Expression.ClockKind.toString to toDebugString, and implemented new toString that doesn't leak implementation details.
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2019-03-26_16-01-18. |
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Mar 26, 2019
- Moved the check of equations inside when-equations from Inst to Typing, to allow skipping the check if the when is clocked. - Mark lhs subscripts in when-equations as structural. - Added check that clocked when doesn't have an elsewhen. - Added check that non-clocked when doesn't have a clocked elsewhen. - Made clocked when illegal in algorithm. - Added new phase VerifyModel that checks for errors that can't be detected until after flattening and constant evaluation. It currently checks that each branch of a when-equation contains the same set of crefs. - Implemented BaseAvlSet.isEqual. - Renamed Expression.ClockKind.toString to toDebugString, and implemented new toString that doesn't leak implementation details. Belonging to [master]: - #3001 - OpenModelica/OpenModelica-testsuite#1148
OpenModelica-Hudson
pushed a commit
to OpenModelica/OpenModelica-testsuite
that referenced
this pull request
Mar 26, 2019
Belonging to [master]: - OpenModelica/OMCompiler#3001 - #1148
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing, to allow skipping the check if the when is clocked.
detected until after flattening and constant evaluation.
It currently checks that each branch of a when-equation contains
the same set of crefs.
implemented new toString that doesn't leak implementation details.