Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding compat #75

Merged
merged 3 commits into from Feb 23, 2023
Merged

Adding compat #75

merged 3 commits into from Feb 23, 2023

Conversation

AnHeuermann
Copy link
Member

@AnHeuermann AnHeuermann commented Feb 21, 2023 •
edited

Adding compatibility from https://github.com/OpenModelica/OMJulia.jl/commits/maintenance/v0.2.0 to register package.
Also remove latest update to version in Project.toml.

Also fixes #69.

@AnHeuermann AnHeuermann self-assigned this Feb 21, 2023
@AnHeuermann
Copy link
Member Author

The Jenkins CI + Dockerfile with Julia 1.0.3 was failing during the test, because of some strange compatibility issue.
It didn't happen to me when I run the Docker image locally, only when running it on a PR.

@sjoelund What do you think? Should we switch from the Jenkins CI to GitHub Action?
It is more flexible and allows us to test arbitrary Julia versions on Linux, Windows and as soon as we have OpenModelica available on Mac (and setup-openoodelica supports it).
The Windows tests are of course way slower than the Linux tests, because the Windows installer is huge. On the next run it should be a bit faster, because the Windows installer will be cached.

@AnHeuermann
Copy link
Member Author

Also @sjoelund would need to change the required tests from Jenkins to Test.yml for this PR to be merged.

@AnHeuermann AnHeuermann force-pushed the adding-compat branch 2 times, most recently from d9f41ed to 2bf158f Compare February 23, 2023 12:15
@AnHeuermann
Switch CI to GitHub action
e41c058 
  - Matrix tests possible for different versions of Julia or OMC.
  - Use AnHeuermann/setup-OpenModelica to set up OpenModelica
  - Use setup-julia for julia
@AnHeuermann AnHeuermann merged commit ae31c37 into OpenModelica:master Feb 23, 2023
@AnHeuermann AnHeuermann deleted the adding-compat branch February 23, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AnHeuermann AnHeuermann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Julia LTS and stable version
1 participant
@AnHeuermann