This repository has been archived by the owner on Apr 3, 2019. It is now read-only.
Use new flag -d=oldFrontEndUnitCheck #764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "NF" unit checking tests use the old frontend for unit checking, which is wrong.
|
The tests run correctly according to OpenModelica_TEST_PULL_REQUEST 2017-11-06_14-07-49. |
OpenModelica-Hudson
pushed a commit
to OpenModelica/OMCompiler
that referenced
this pull request
Nov 6, 2017
Set the cref hashtable to an appropriate size at the start. Also re-added the `-d=-frontEndUnitCheck` flag which was previously not used in the new frontend always enabling the unit checking. This has the default set to true with the ability to disable the phase. Belonging to [master]: - #1978 - OpenModelica/OpenModelica-testsuite#764
OpenModelica-Hudson
pushed a commit
to OpenModelica/OMCompiler
that referenced
this pull request
Nov 6, 2017
We use a fake stack overflow to signal some logic error in the templates. This also checks for a real stack overflow so we can report the stack overflow message. Belonging to [master]: - #1978 - OpenModelica/OpenModelica-testsuite#764
OpenModelica-Hudson
pushed a commit
that referenced
this pull request
Nov 6, 2017
The "NF" unit checking tests use the old frontend for unit checking, which is wrong. Belonging to [master]: - OpenModelica/OMCompiler#1978 - #764
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "NF" unit checking tests use the old frontend for unit checking,
which is wrong.