Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Change libomqwt to shared library. (#11103)
- This reverts changes made in #9939 and #9956. - It should be a shared library (a DLL on Windows at least) because it is used by both `libOMPlotLib.dll` and `OMNoteBook.exe`. However, `OMNoteBook.exe` links to `libOMPlotLib.dll` as well. CMake will add both `libOMPlotLib.dll` and `libomqwt.a` to the linking commandline of `OMNoteBook.exe` and that causes duplicates on some configurations (e.g. using `clang` on `OMDev`. Curiously the issue does not occur with `gcc` on `OMDev`). - Another way to fix this problem would be to make the linking by `libOMPlotLib.dll` to static `libomqwt.a` a PRIVATE link (in CMake terms.) However, that will require us to manually add the definitions and include directives needed to use `libomqwt.a` by `OMNoteBook.exe` (think of it like `OMNoteBook.exe` uses both `libOMPlotLib.dll` and `libomqwt.a`, not just `libOMPlotLib.dll`). So the most logical and straightforward fix is to make `libomqwt` a shared lib.
- Loading branch information